Feature branch code reviews
Great article about coding workflow from Thoughbot.
Here’s the flow. Read Josh Susser’s post. for the git commands.
- Start a user story.
- Code the feature.
- Push the feature to a branch.
- A Github hook starts a CI build.
- A Github Campfire hook posts your work to Campfire.
- Click the link that’s in Campfire.
- Click the Github “Pull Request” button.
- It will smartly select all commits in your branch that are not in master.
- Create the pull request.
- Ask your team in Campfire for a review of the pull request.
- The team comments in-line, right on the code.
- Make the suggested changes.
- Merge into master.
- Push to master.
- CI runs again.
- Deploy to staging.